Suite to Xero

Hey jan, looks like it is a PHP version error if you're still interested in the module, it appears to validate on PHP 7.4 and no higher. If you're still interested in the module, get back to me and I'll tell you when the code has been changed so you can test it

Thanks for your time and patience

Hey Jan, it is/was a simple? error with the validation code that is being used for your license. A simple change to the /modlues/bfs_SuitetoXero/license/OutfittersLicense.php file, line 360 is required. Change private function to private static function, save your changes and it should work

Hey Info170, I ran up a test installation of Suite and did some test runs using PHP8.2 it appears that that is the problem. The validation completed successfully using PHP 7.4. I'm checking now to see what is the 'highest' version of PHP the validation is successful with and will get back to you with those results, so that you could at least test the module while I identify what needs to be changed code wise. When I have completed and tested those changes I'll send you the relevant files - if you're still interested

Thanks for your time and patience

Hey, looks like PHP 7.4 is the most recent version that is working for license validation. I'll get back to you when code has been re-written...

Ok thank you!

Hey info170, it is/was a simple? error with the validation code that is being used for your license. A simple change to the /modlues/bfs_SuitetoXero/license/OutfittersLicense.php file, line 360 is required. Change ~~~ private function ~~~ to ~~~ private static function ~~~, save your changes and it should work

I can't however guarantee that the module will work with your version of SuiteCRM, sure hope it does, I've never tested it on that version. Would be grateful for your feedback on how it goes?

Apols for any inconvenience this might have caused you and I hope that the module does in fact deliver the functionality that you require

Cheers mate

Thanks- that fixed the validation error. Now when I create the xero config and hit 'connect to xero' i get an error 500 'something went wrong'. and now when I try to connect again I don't get the option for 'connect to xero' anymore... is this something related to the newer PHP you think?

Hey info, thanks for bearing with me as I work through your problem. I'm making an assumption here but the plugin has NEVER been verified with any of the most recent versions of Suite, the 8.x versions. The plugin was originally designed for any of the 7.x and earlier versions. Suite 8.x was/is a fairly major architecture re-design. I'll run up a test install and see if I can get it to work, but TBH I'm probably looking at a re-build of the module to work with the new Suite architecture as I'm not entirely sure whether and how it supports 'legacy' plugins. That would probably entail a lot of work and I'm not entirely sure the number of sales we're getting would support that time and effort BUT, it might be simpler than I imagine so I'll have a look at it and get back to you as soon as I have something concrete to tell you.

Once again, thanks for your time and patience with this problem. Oh, one quick thing you might be able to do? Open the Developer Tools console in your browser and try the connect to Xero thing again, it may be the same sort of problem that we've found for the licensing code - that'd be a quick fix. Copy any errors that appear in the console and send them to me?

Cheers mate

OK- I may try and install the 7.4 php version and remove 8.2 but I'm not sure how that will work with the existing environment. I'll look at the developer console tomorrow and let you know. Thanks for your support!

Quick reply - unfortunately there is NO way the module as it is currently coded will work with SuiteCRM 8.x, the underlying architecture changes are too comprehensive. The most recent SuiteCRM version it should work with is v7.14 and, after the changes you made earlier, it will work with PHP 8.2 on that platform.

Apologies for 'mucking' you around and wasting your time. I've put a heading on the module home page stating that it doesn't work with SuiteCRM 8.x, hopefully that will prevent others from having to go through the same experience. Also, thanks for actually replying to me when I asked you about the platform, versions etc you were running on. I had previously had a couple of other queries with the same problem but none of them replied so I couldn't figure out what the problem was, let alone how to fix it, so big ups for that.

I haven't decided whether or not to re-code the entire module so that it works with SuiteCRM 8.x, but if I do, you'll be able to see it listed here as a package/module specifically for that version.

Cheers

Ok no problem, thanks for the update. I'll try again with a fresh 7.14 version of suitecrm, and php 8.2 with the changes to the license verification we did.

Just wanted to update you- I installed 7.14 with php 8.2 and it installs the module fine, key validates and connect to xero works now. But we get the below error when creating a contact and syncing with xero:

Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /var/www/html/suitecrm714/modules/bfs_SuitetoXero/library/entrypoints/sendContacttoXero.php:146 Stack trace: #0 /var/www/html/suitecrm714/custom/entrypoints/XeroOAuth-PHP-master/BfsSuitetoXeroHook.php(865): include_once() #1 /var/www/html/suitecrm714/custom/entrypoints/XeroOAuth-PHP-master/SuiteHooks.php(48): BfsSuitetoXeroHook->syncToXero() #2 /var/www/html/suitecrm714/include/utils/LogicHook.php(261): SuiteHooks->syncToXero() #3 /var/www/html/suitecrm714/include/utils/LogicHook.php(197): LogicHook->process_hooks() #4 /var/www/html/suitecrm714/data/SugarBean.php(3190): LogicHook->call_custom_logic() #5 /var/www/html/suitecrm714/data/SugarBean.php(2432): SugarBean->call_custom_logic() #6 /var/www/html/suitecrm714/include/SugarObjects/templates/person/Person.php(210): SugarBean->save() #7 /var/www/html/suitecrm714/modules/Contacts/ContactFormBase.php(600): Person->save() #8 /var/www/html/suitecrm714/modules/Contacts/Save.php(48): ContactFormBase->handleSave() #9 /var/www/html/suitecrm714/include/MVC/View/SugarView.php(824): include_once('...') #10 /var/www/html/suitecrm714/include/MVC/View/views/view.classic.php(72): SugarView->includeClassicFile() #11 /var/www/html/suitecrm714/include/MVC/View/SugarView.php(210): ViewClassic->display() #12 /var/www/html/suitecrm714/include/MVC/Controller/SugarController.php(432): SugarView->process() #13 /var/www/html/suitecrm714/include/MVC/Controller/SugarController.php(363): SugarController->processView() #14 /var/www/html/suitecrm714/include/MVC/SugarApplication.php(101): SugarController->execute() #15 /var/www/html/suitecrm714/index.php(52): SugarApplication->execute() #16 {main} thrown in /var/www/html/suitecrm714/modules/bfs_SuitetoXero/library/entrypoints/sendContacttoXero.php on line 146

Hey info, looks like you're running into more problems with this implementation and PHP 8.2. There are a number of files (10 at my last count) that have the possibility of throwing this error, and possibly/probably? more... I'll have a run through them, and see if it's the same type of error and, we get to the time spent re-coding worth return on sales problem, bloody economics....

That being the case, I will look through those files and run some tests of my own. Generally because I think it's a good implementation/solution for any business using Suite and Xero and I like having customers who are happy with that solution. Hopefully everything balances out and I can create a solution that works for you...

I will also try and uninstall php 8.2 and install 7.4. I believe you said that should work fine. One question I have that I'm not sure you can answer is our trial key expires in 3 days for suite to xero, however since we haven't had a chance to actually test anything yet, is it possible to get a new trial key for another 30 days? Thanks

Hey Info, I'll look into extending your trial later today... will get back to you with updates

Cheers

Trial has been extended 1 month....

thank you!